Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Ubuntu 16.04 (EOL) #1507

Merged
merged 10 commits into from
Aug 16, 2022
Merged

Drop Ubuntu 16.04 (EOL) #1507

merged 10 commits into from
Aug 16, 2022

Conversation

smortex
Copy link
Member

@smortex smortex commented Aug 12, 2022 •
edited
Loading

This PR also include:

@puppet-community-rangefinder
Copy link

nginx::package::redhat is a class

that may have no external impact to Forge modules.

This module is declared in 9 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@smortex smortex changed the title ubuntu16 Drop Ubuntu 16.04 (EOL) Aug 12, 2022
@smortex smortex mentioned this pull request Aug 12, 2022
Merged
@smortex
Fix CentOS 7 / CentOS Stream 8 in CI
7b03bb5 
Ensure we are using nginx from the correct repo: cleanup leftovers from
previous tests. Also, the passenger repository is not usable on CentOS
Stream 8, and the packaged version is too old for some of our tests
(e.g. when using nginx-mod-mail).

```
Error:
 Problem: cannot install the best candidate for the job
  - nothing provides rubygem(rack) needed by passenger-6.0.14-1.el8.x86_64
```

```sh-session
[vagrant@centos8s ~]$ dnf info nginx-mod-mail
Last metadata expiration check: 0:00:08 ago on Fri 12 Aug 2022 01:23:41 AM UTC.
Available Packages
Name         : nginx-mod-mail
Epoch        : 1
Version      : 1.14.1
Release      : 9.module_el8.0.0+1060+3ab382d3
Architecture : x86_64
Size         : 64 k
Source       : nginx-1.14.1-9.module_el8.0.0+1060+3ab382d3.src.rpm
Repository   : appstream
Summary      : Nginx mail modules
URL          : http://nginx.org/
License      : BSD
Description  : Nginx mail modules.
```
bastelfreak
bastelfreak approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there maybe some Ubuntu 16 code we can also drop?
at least manifests/params.pp has some code we can drop

@smortex smortex merged commit 82ead9d into master Aug 16, 2022
@smortex smortex deleted the ubuntu16 branch August 16, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smortex @bastelfreak