Fix RHEL installation support #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfryman
pushed a commit
that referenced
this pull request
Oct 16, 2013
Fix RHEL installation support
jfryman
pushed a commit
that referenced
this pull request
Oct 25, 2013
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 7ea6b57 broke RHEL support by introducing the parameters
package_nameandpackage_sourceinpackage.ppbut those parameters are not supported inpackage/redhat.pp.This pull request fixes the problem and also consolidates redhat.pp to match the style of debian.pp. This includes replacing the
$redhat_packagesparameter (a list of packages) with simply$package_name. Checking the latest nginx in EPEL for RHEL6 all related packages with the exception of libXpm are already specified as dependencies in thenginxRPM. I haven't found out whylibXpmwas listed in$redhat_packagesin the first place.