Add the possibility to add a header to the HTTP response #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e code is equal to 200, 204, 301, 302 or 304.
| @@ -26,6 +26,9 @@ server { | |||
| <% @proxy_set_header.each do |header| -%> | |||
| proxy_set_header <%= header %>; | |||
| <% end -%> | |||
| <% if @add_header -%><% @add_header.each do |key,value| -%> | |||
There was a problem hiding this comment.
Neat! You should cast @add_header as an Array in the event a user only wants to provide one header to be added. See https://github.com/jfryman/puppet-nginx/blob/master/templates/vhost/vhost_location_directory.erb#L21 for an example of this.
|
Thankx for you're fast feedback! The add_header directive should be a key, value pair in Nginx (Syntax: add_header name value). I've used the hash data type in Puppet to make sure there is always a key > value pair used. To prevent invalid input I've implement some validation in my 2nd commit. Please could you verify my request? |
|
@hdanes love it! The validation makes much more sense here. Thanks for the code! |
jfryman
pushed a commit
that referenced
this pull request
Dec 24, 2013
Add the possibility to add a header to the HTTP response
This was referenced Dec 30, 2013
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
Add the possibility to add a header to the HTTP response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when response code is equal to 200, 204, 301, 302 or 304.
For Example:
nginx::resource::vhost { 'example.com':
add_header => {
'Strict-Transport-Security' => 'max-age=15768000',
},
}