Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for duplicate listen option caused by hardcoded ipv6only=on in template #249

Merged

Conversation

fadenb
Copy link

@fadenb fadenb commented Feb 3, 2014

The hardcoded ipv6only=on listen option in mailhost.erb, mailhost_ssl.erb, vhost_header.erb and vhost_ssl_header.erb cause nginx to fail:
duplicate listen options for [::]:80 in /etc/nginx/sites-enabled/ [...]

To avoid this I moved ipv6only=on from the templates into the puppet code. This way it should be backwards compatible if no listen options are passed to the define type.

Tristan Helmich added 2 commits February 3, 2014 12:54
Specs no longer require `ipv6only=on` in listen option when using user
supplied value since it is no longer hardcoded in the template.
@jfryman
Copy link
Contributor

jfryman commented Feb 4, 2014

Dig it. 👍

jfryman pushed a commit that referenced this pull request Feb 4, 2014
Bugfix for duplicate listen option caused by hardcoded `ipv6only=on` in template
@jfryman jfryman merged commit de42889 into voxpupuli:master Feb 4, 2014
@fadenb fadenb mentioned this pull request Feb 4, 2014
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this pull request Oct 23, 2017
…ion_ipv6only

Bugfix for duplicate listen option caused by hardcoded `ipv6only=on` in template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants