Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow location_{allow,deny} parameter to be used for proxy locations #253

Merged

Conversation

fadenb
Copy link

@fadenb fadenb commented Feb 7, 2014

It should be possible to set allow/deny rules per proxied locations.

@jfryman
Copy link
Contributor

jfryman commented Feb 10, 2014

This should probably have some validate_array resources in nginx::resource::location as well. Mind adding?

@fadenb
Copy link
Author

fadenb commented Feb 10, 2014

Ok, will do that today / tomorrow.

@fadenb
Copy link
Author

fadenb commented Feb 11, 2014

@jfryman seems like those validate_array were already implemented by @3flex and merged by you (#227) :)

@jfryman
Copy link
Contributor

jfryman commented Feb 11, 2014

HA! So it seems! Derp on me.

Then, by the powers vested in me by the Meritocracy of GitHub, I hereby merge this Pull Request. It shall hold all the rights and privileges as all other bits in this repository from this day forward.

So Say We All.

Thanks for the code!

jfryman pushed a commit that referenced this pull request Feb 11, 2014
…ion_proxy

Allow location_{allow,deny} parameter to be used for proxy locations
@jfryman jfryman merged commit 047b88d into voxpupuli:master Feb 11, 2014
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this pull request Oct 23, 2017
…ost_location_proxy

Allow location_{allow,deny} parameter to be used for proxy locations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants