add service_ensure support #264
Conversation
| @@ -44,6 +44,7 @@ | |||
| $proxy_cache_inactive = $nginx::params::nx_proxy_cache_inactive, | |||
| $configtest_enable = $nginx::params::nx_configtest_enable, | |||
| $service_restart = $nginx::params::nx_service_restart, | |||
| $service_ensure = $nginx::praams::nx_service_ensure, | |||
|
Fixed. Quite likely did not make a difference though, as it is defined in service.pp as well. |
| @@ -15,16 +15,24 @@ | |||
| # This class file is not called directly | |||
| class nginx::service( | |||
| $configtest_enable = $nginx::params::nx_configtest_enable, | |||
| $service_restart = $nginx::params::nx_service_restart | |||
| $service_restart = $nginx::params::nx_service_restart, | |||
There was a problem hiding this comment.
What do you think about making these source $nginx::service_ensure? that way, the overrides will pass through.
There was a problem hiding this comment.
Sure.. that's another way to solve the problem. I just didn't want to do things differently from the other parameters.
There was a problem hiding this comment.
Understood. I'd like to change that everywhere, so go ahead and start the precedence. 😁
There was a problem hiding this comment.
Currently trying to fix the unit tests to support the change. I guess that's one of the drawbacks of this method - that testing (sub-)modules independently of each other becomes more complicated (well.. at least testing for default values).
add service_ensure support
Makes it possible to disable the default service resource in case a different supervision system is used (for docker containers for instance)