Allow values to be hashes at prepend,append,custom cfg for locations

[ese]

Some times you need to add the same parameter many times ( for example add_header or proxy_set_header) at location scope.

This workaround allow use hashes for this purpose

For example:

nginx::nginx_locations:
  'location_name':
    vhost: example.com
    location: /
    proxy: "http://unicorn"
    location_cfg_append:
      proxy_set_header:
        Host: '"$host"'
        X-Forwarded-For: '"$proxy_add_x_forwarded_for"'

result:

  location / {
    proxy_pass          http://unicorn;
    proxy_read_timeout  90;
    proxy_set_header Host "$host";
    proxy_set_header X-Forwarded-For "$proxy_add_x_forwarded_for";
  }

[jfryman]

Wow! This is pretty awesome. I'd love to see some tests wrapped here.

[ese]

I have been looking for but i dont understand why the tests fail.

[grooverdan]

warning this probably needs merging with #201

watch the white space and differences in tests. Its probably the cause

[grooverdan]

i've started a merge https://github.com/openquery/puppet-nginx/tree/hash

[ese]

all tests works now, after a lot of pain.

I dont consider errors in ruby 1.8.7 (It is only a little different behavior in sort) becouse it has no support and no maintenance since june 2013

[jfryman]

I'm hesitant to merge this even with the failing tests. Do you know the root cause?

[ese]

I dont know but its possible stop support ruby 1.8.7 in tests editing .travis.yml

I can do the change and push, i think its better than merge with broken tests

[grooverdan]

Wow. Thanks @ese. Well done and I really appreciate the effort here to fix these kinds of tests.

Looks great to me. Ready to merge @jfryman ? (and sorry for the noise in the mean time)

[jfryman]

This is looking really good. Stellar job on both of your parts, @ese and @grooverdan! 👏

I dont consider errors in ruby 1.8.7 (It is only a little different behavior in sort) becouse it has no support and no maintenance since june 2013

I thought about this point over the weekend. I'm 👍 on removing the 1.8.7 tests. However, this should be documented in the readme. Would one of you add this?

Also, does this PR make #273 necessary?

Finally, this functionality should be more visible. Can you provide some commentary on when to use this, along with some examples?

Once this lands, I'll also cut a new release for the forge.

[mschuett]

Will there be any way to insert custom text?

I really liked the previous solution #259 because it allowed me to add a custom if condition into templates.
With the current version this is no longer possible, as the added ';' breaks nginx syntax.

[grooverdan]

vhost_cfg_prepend => { '' => 'if ($slow) { limit_rate 10k; break; } set $dummy value' },

Not pretty I agree. Would a condition if the text ends in '}' then no ';' is added? Is this even possible?

[mschuett]

Actually I am not sure why everything needs to fit into a hash... The fact that it is a custom attribute already means it does not fit into the common structure.

Right now we are happily running commit 7cf6dac. -- If necessary I will just fork a branch with a custom_custom_cfg_prepend attribute.

[abraham1901]

FUCK!!!
Why hash? Why ';' ?
It's options for logical structures such as if, whithout ';'

[location_custom_cfg_prepend] - Expects a array with extra directives
to put before anything else inside location (used with all other types
except custom_cfg). Used for logical structures such as if.
[location_custom_cfg_append] - Expects a array with extra directives
to put before anything else inside location (used with all other types
except custom_cfg). Used for logical structures such as if.

[abraham1901]

Remove char ';' in PR #295