Use first server name for non-www redirects to prevent issues with naming of vhosts within defined types. #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please rebase? |
…ming of vhosts within defined types. Signed-off-by: Kalman Olah <kalman@inuits.eu>
|
@jfryman there |
|
Super! Thanks for the add! |
jfryman
pushed a commit
that referenced
this pull request
Jun 26, 2014
Use first server name for non-www redirects to prevent issues with naming of vhosts within defined types.
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
Use first server name for non-www redirects to prevent issues with naming of vhosts within defined types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I were to define a type named
reverse_proxy_vhostand name the nginx vhosts insidereverse_proxy_${name}while providing custom values forserver_nameand settingrewrite_www_to_non_wwwto true, it would result in something likereverse_proxy_mydomain.netas the server name.This PR resolves that.