Pull request 269 revisited #314
Conversation
|
Looks like it needs another rebase... :/ |
|
Yet another try! |
|
This is really super. I'd love it if another community member would also look and give a 👍 before this merges, since it is quite a large change. |
|
I am testing it a bit more at the moment. I expect to submit som small fixes shortly. |
|
Added for more config options to remove all references to params. This resolved and issue with proxy_read_timeout from previous patches. |
|
This is becoming a big patch so I don't know how we take this further. |
|
Rebased pull request. |
|
It is becoming a bit tedious to rebase all the time. Can we do something different? |
|
Yeah, I was thinking the same thing earlier as well. It's just too big and keeps getting hit by the blast radius of other pulls. |
|
Slightly thinner. Will work on breaking out some more. |
|
Any help required on this? There are some changes I need and I'd love to see this merged. |
|
I am shrinking this pull request by breaking out parts of it. Feel free to take a stab on it and take some options and create a new pull request. I will rebase when they have been merged and I guess at one stage this request will be small enough ;-) |
|
I have rebased this again. How much smaller do you want me to make it? Some of these variable changes touches a lot of code. |
|
This patch is now reduced to adding the following parameters: |
- make many more things configurable - stop using ::params::* for things that are configurable - add worker_rlimit_nofile option - add tcp_nopush option
|
👍 |
|
Alright. Looks alright to me, and tests pass. Let's go with it. Many ❤️ for working on this! |
|
Thanks! Now I can concentrate on other changes ;-) |
|
I guess PR #269 could be closed now. |
I have rebased Pull request 269.
This patch is now reduced to adding the following parameters:
client_body_temp_path
http_tcp_nodelay
http_tcp_nopush
keepalive_timeout
logdir
mail
pid
proxy_temp_path
run_dir
sendfile
spdy
temp_dir