Upstream members can be exported and collected #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exported and collected.
jfryman
pushed a commit
that referenced
this pull request
Jun 11, 2014
Upstream members can be exported and collected
|
Love it! |
leepa
added a commit
to Unity-Technologies/puppet-nginx
that referenced
this pull request
Jun 12, 2014
Upstream members can no longer be exported and collected. The change in voxpupuli#331 was fundamentally broken. I have therefore reverted it as it shouldn't of been merged. Essentially you can't use ensure with this change - meaning you can no longer REMOVE an nginx config from the system - which is part of the tests and also sane module practice. The idea was nice - but the implementation broke things. This reverts back to a good state, without modifying any tests where tests pass again with the recent commits. This reverts commit ebf3e4e.
This was referenced Jun 20, 2014
Closed
rabbitt
added a commit
to rabbitt/puppet-nginx
that referenced
this pull request
Jun 21, 2014
- resurrecting voxpupuli#331 from @rainopik - update (concat/stdlib) dependency version requirements based on current usage - fix upstream tests to match rainopik's changes in what was voxpupuli#331
rabbitt
added a commit
to rabbitt/puppet-nginx
that referenced
this pull request
Jun 21, 2014
- resurrecting voxpupuli#331 from @rainopik - update (concat/stdlib) dependency version requirements based on current usage - fix upstream tests to match rainopik's changes in what was voxpupuli#331
rabbitt
added a commit
to rabbitt/puppet-nginx
that referenced
this pull request
Jun 21, 2014
- resurrecting voxpupuli#331 from @rainopik - update (concat/stdlib) dependency version requirements based on current usage - fix upstream tests to work with rainopik's changes in what was voxpupuli#331
jfryman
pushed a commit
that referenced
this pull request
Jun 24, 2014
Reintegrate #331 (upstream exports/collections)
janorn
pushed a commit
to janorn/puppet-nginx
that referenced
this pull request
Jun 24, 2014
- resurrecting voxpupuli#331 from @rainopik - update (concat/stdlib) dependency version requirements based on current usage - fix upstream tests to work with rainopik's changes in what was voxpupuli#331
This was referenced Sep 24, 2014
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
Upstream members can be exported and collected
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
Upstream members can no longer be exported and collected. The change in voxpupuli#331 was fundamentally broken. I have therefore reverted it as it shouldn't of been merged. Essentially you can't use ensure with this change - meaning you can no longer REMOVE an nginx config from the system - which is part of the tests and also sane module practice. The idea was nice - but the implementation broke things. This reverts back to a good state, without modifying any tests where tests pass again with the recent commits. This reverts commit ebf3e4e.
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
- resurrecting voxpupuli#331 from @rainopik - update (concat/stdlib) dependency version requirements based on current usage - fix upstream tests to work with rainopik's changes in what was voxpupuli#331
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
Reintegrate voxpupuli#331 (upstream exports/collections)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows to declare upstream members on actual member servers.
I wanted a way to dynamically populate the members array as I spin up additional member servers (similar to haproxy::balancermember), but could not find any better way.
I've split the upstream.erb template into several parts and made the members parameter optional. If members is omitted, at least one upstream member should be declared (or the nginx will complain on reload).
Example: