Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uwsgi support #398

Merged
merged 8 commits into from
May 8, 2015
Merged

Add uwsgi support #398

merged 8 commits into from
May 8, 2015

Conversation

mvintila
Copy link
Contributor

Add uwsgi support, very similar to fastcgi. Actually most of the code is just copied over from the fastcgi functionality. This is tested and currently running in a production environment.

@mvintila
Copy link
Contributor Author

mvintila commented May 8, 2015

Tests are fixed, would be nice if this was merged eventually.

@jfryman
Copy link
Contributor

jfryman commented May 8, 2015

@mvintila thanks for the code.

Yeah, I'm good with this. I know it can be done with custom directives, but this is cool to merge.

jfryman added a commit that referenced this pull request May 8, 2015
@jfryman jfryman merged commit 086510c into voxpupuli:master May 8, 2015
@3flex
Copy link
Contributor

3flex commented May 8, 2015

Why doesn't uwsgi_params match upstream? What was committed contains this extra line:

uwsgi_param SERVER_ADDR $server_addr;

@mvintila
Copy link
Contributor Author

mvintila commented May 8, 2015

What do you mean? The file is identical to the example here:
http://uwsgi-docs.readthedocs.org/en/latest/Nginx.html

@3flex
Copy link
Contributor

3flex commented May 8, 2015

This is the current file in nginx source: http://trac.nginx.org/nginx/browser/nginx/conf/uwsgi_params

You wouldn't include uwsgi_param HTTPS $https if_not_empty; from upstream because that's only supported in nginx 1.1.1 and higher, but otherwise I'd expect the file in this module to match upstream.

@3flex
Copy link
Contributor

3flex commented May 8, 2015

@jfryman what do you want to do here? I'm trying to avoid a repeat of #500

cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this pull request Oct 23, 2017
Slm0n87 pushed a commit to Slm0n87/puppet-nginx that referenced this pull request Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants