Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow internal-only location resources #464

Merged
merged 1 commit into from
Sep 25, 2014

Conversation

danieldreier
Copy link
Contributor

This is a re-implementation of #388 because it hasn't been rebased and I need the changes it makes.

Location resources with internal == true are valid in nginx, but the module does
not allow them unless one or more of www_root, proxy, location_alias,
stub_status, fastcgi, or location_custom_cfg are set

This patch allows locations with none of those but internal == true to
be created.

Location resources with internal == true are valid, but the module does
not allow them unless one or more of www_root, proxy, location_alias,
stub_status, fastcgi, or location_custom_cfg are set

This patch allows locations with none of those but internal == true to
be created.

This is a re-implementation of jfryman/nginx PR-388.
@actown
Copy link

actown commented Sep 25, 2014

+1

@danieldreier
Copy link
Contributor Author

@3flex this is the rebase you requested for PR-388

@3flex
Copy link
Contributor

3flex commented Sep 25, 2014

@jfryman please review and merge if you're happy with this, +1 from me.

Just wondering if this might conflict with anything you had in the pipeline for vhost resources.

jfryman added a commit that referenced this pull request Sep 25, 2014
Allow internal-only location resources
@jfryman jfryman merged commit 42b427b into voxpupuli:master Sep 25, 2014
@jfryman
Copy link
Contributor

jfryman commented Sep 25, 2014

@danieldreier thanks so much for the code!

@danieldreier danieldreier deleted the allow_internal_only branch September 26, 2014 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants