Add passenger_set_header and passenger_env_var parameters for Passenger 5.0+ #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 29, 2015 12:24
…o support Passenger 5.0+
…to support Passenger 5.0+
| <% end -%> | ||
| <% if @passenger_env_var -%> | ||
| <%- @passenger_env_var.keys.sort.each do |key| -%> | ||
| passenger_set_env_var <%= key %> <%= @passenger_env_var[key] %>; |
There was a problem hiding this comment.
The directive name according to passenger docs is passenger_env_var.
There was a problem hiding this comment.
I was following the pattern for 'passenger_set_cgi_param' which only uses 'set' in the template when it is actually writing the config.
…lso passenger_env_var is not set with passenger_set_env_var and this commit undoes that
mmarod
changed the title
|
Yeah, several existing parameters don't match the name of the nginx directives, but it's certainly something we'd like to avoid in future. Thanks for updating! |
3flex
added a commit
that referenced
this pull request
Apr 30, 2015
Add passenger_set_header and passenger_env_var parameters for Passenger 5.0+
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
Add passenger_set_header and passenger_env_var parameters for Passenger 5.0+
Slm0n87
pushed a commit
to Slm0n87/puppet-nginx
that referenced
this pull request
Mar 7, 2019
Add passenger_set_header and passenger_env_var parameters for Passenger 5.0+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passenger 5.0 deprecates passenger_set_cgi_param and replaced it with passenger_set_header and passenger_env_var. This allows you to specify those parameters.
https://blog.phusion.nl/2015/03/04/phusion-passenger-5-0-1-released/