Add 'ensure' parameter to resource::upstream::member. #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is no way to ensure => absent. I'm using these with stored configs to have servers register the member only, not the upstream. Removing them in a mis-configured incident is a bit of a burden without ensure => absent. Tests are passing under Ruby 2.1
|
Looks great. Thanks for the code! |
jfryman
added a commit
that referenced
this pull request
Aug 31, 2015
Add 'ensure' parameter to resource::upstream::member.
Slm0n87
pushed a commit
to Slm0n87/puppet-nginx
that referenced
this pull request
Mar 7, 2019
Add 'ensure' parameter to resource::upstream::member.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using stored configs to create upstream::member on servers that should belong to up upstream. Removing them while developing the puppet manifests if something goes wrong is troublesome without the ability to ensure => absent.
All tests are passing under ruby 2.1.2, though I didn't add new ones.