Fix streams support #790
Closed
Fix streams support #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They inherit properties from sites_available.
Nginx error: nginx: [emerg] "server_name" directive is not allowed here As of version 1.9.10 at least.
It creates nginx::resource::streamhost resources.
|
Hi @modax, thanks for the PR. Can you please rebase and add tests for it? |
|
We also merged #790 which adds a bit of the functionality from here. |
This was referenced Oct 13, 2016
Merged
Merged
|
Replacing with #933 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a couple fixes/improvements for nginx streams. See individual commits for more information.