Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigation for US-CERT VU#797896 #833

Closed
wants to merge 1 commit into from

Conversation

abrander
Copy link

@abrander abrander commented Jul 19, 2016

US-CERT VU#797896 (and others) describes an attack where an end-user is capable of overriding the proxy setting for multiple FastCGI backends.

I propose we help mitigate this attack by removing the variable before reaching the backend as proposed by multiple vendors and industry players.

Sources:
https://www.kb.cert.org/vuls/id/797896
https://httpoxy.org/
https://www.nginx.com/blog/mitigating-the-httpoxy-vulnerability-with-nginx/

Relevant CVEs:
CVE-2016-5385: PHP
CVE-2016-5386: Go
CVE-2016-5387: Apache HTTP Server
CVE-2016-5388: Apache Tomcat
CVE-2016-1000109: HHVM
CVE-2016-1000110: Python

@FlorianSW
Copy link
Contributor

This doesn't cover the case, where you proxy the request to another server, e.g. if you use nginx only for ssl termination and the actual execution of any application is made internally by Apache or another nginx server or whatever crazy setups there're used in the wild. So I would propose to set
proxy_set_header Proxy "";
just in case, too (in templates/vhost/locations/proxy.erb). There is nearly no reason I can imagine, where you would need this header and if so, we probably can make it configurable but enabled by default.

@abrander
Copy link
Author

I think this is better solved by #835 - I'll close this PR.

@abrander abrander closed this Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants