add auth_http_header #898
Merged
add auth_http_header #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tjikkun: can you add tests for this? |
tjikkun
force-pushed
the
auth_http_header
branch
from
30df652
to
54abf2a
Compare
tjikkun
force-pushed
the
auth_http_header
branch
from
54abf2a
to
7cc43fd
Compare
|
@wyardley Thanks for looking, I have added tests now |
dhoppe
approved these changes
Oct 7, 2016
|
Thanks for the quick changes! Looks good to me |
|
The documentation of the class parameter is missing in the manifests/resource/mailhost.pp file. If it's ok I'll add it in the #769 rebase. |
|
@dol: adding docs is always a good thing. We're hoping to rework the docs in general, since the module obviously could be better documented, but definitely feel free to add it in your PR. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
add auth_http_header
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
add auth_http_header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to specify auth_http_header in mailhost