Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump puppet minimum version_requirement to 3.8.7 #989

Merged
merged 1 commit into from
Dec 21, 2016

Conversation

juniorsysadmin
Copy link
Member

We currently only run automated tests against Puppet 3 latest and
therefore cannot guarantee that this module works as is expected with
earlier Puppet 3 versions

Also remove deprecated pe version_requirement

Also remove explicit references to Ruby and Facter versions

@rnelson0 rnelson0 added the needs-work not ready to merge just yet label Dec 21, 2016
We currently only run automated tests against Puppet 3 latest and
therefore cannot guarantee that this module works as is expected with
earlier Puppet 3 versions

Also remove deprecated pe version_requirement

Also remove explicit references to Ruby and Facter versions
@wyardley wyardley merged commit fb8a8dc into voxpupuli:master Dec 21, 2016
@rnelson0 rnelson0 removed the needs-work not ready to merge just yet label Dec 21, 2016
@wyardley
Copy link
Collaborator

This looks pretty good to me, I've been thinking the same thing.
I could go both ways in terms of the Ruby version requirement in docs, but I think it'll be OK without.

@juniorsysadmin juniorsysadmin deleted the minpup branch December 23, 2016 05:48
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this pull request Sep 13, 2019
Bump puppet minimum version_requirement to 3.8.7
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
Bump puppet minimum version_requirement to 3.8.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants