Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global_config_entries parameter #457

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fe80
Copy link

@fe80 fe80 commented Jun 20, 2022

Pull Request (PR) description

Hello

This commit add the possibility to create nodejs::npm::global_config_entry resources with hiera declaration.

I've also bootstrap a hiera context on this module.

This Pull Request (PR) fixes the following issues

n/a

manifests/init.pp Outdated Show resolved Hide resolved
@@ -26,6 +28,7 @@
$repo_url_suffix = $nodejs::params::repo_url_suffix,
Array $use_flags = $nodejs::params::use_flags,
Optional[String] $package_provider = $nodejs::params::package_provider,
Hash $global_config_entries,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make the datatype a bit stricter? Do we only allow strings?

Suggested change
Hash $global_config_entries,
Hash[String[1],String[1]] $global_config_entries = {},

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hash[String[1], Hash, 0] instead of Hash[String[1],String[1]] no ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants