allow bin_path overrides for custom redis installs #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
requested changes
Oct 9, 2021
spec/classes/redis_spec.rb
Outdated
| describe 'with parameter: bin_path' do | ||
| let(:params) { { bin_path: '/usr/bin' } } | ||
|
|
||
| it { is_expected.to contain_file('/usr/bin').with_ensure('directory') } |
There was a problem hiding this comment.
This resource is not managed by this module (and I don't think it should). Can you please delete this test?
There was a problem hiding this comment.
I suppose this test can be converted to test the systemd service file's ExecStart and ExecStop directives.
There was a problem hiding this comment.
@aamerik please add the test I mentioned above, else someone may break that in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow overrides for binary path parameter, bin_path, to support custom redis builds and install paths.