Fix puppet-redis for Redis < 3 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent commit [1] broke the support of Redis < 3 when using this Puppet module. The parameter 'cluster-enabled' was set to False by default, but since Redis Clustering has been brought in Redis >= 3, Redis < 3 fails to start [2]: "FATAL CONFIG FILE ERROR" It was an backwards-incompatible change in puppet-redis and we can fix it by just not setting the paramter if 'cluster_enabled' is set to False (default). This patch drops the 'else' statement in the redis.conf template so by default the cluster-enabled setting won't appear in the configuration file. It will fix Redis < 3 support and when running Redis >=3, it will just not activate clustering. This change is compatible with both versions. [1] 4fb33b9 [2] http://stackoverflow.com/questions/27835659/redis-cluster-support-in-redis-2-8-19
|
Ah! That's quite an obvious one. |
|
And of course thanks for fixing it! |
|
@arioch no problem at all! Thanks for your responsiveness! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit [1] broke the support of Redis < 3 when using this
Puppet module.
The parameter 'cluster-enabled' was set to False by default, but since
Redis Clustering has been brought in Redis >= 3, Redis < 3 fails to
start [2]:
"FATAL CONFIG FILE ERROR"
It was an backwards-incompatible change in puppet-redis and we can fix
it by just not setting the paramter if 'cluster_enabled' is set to False
(default).
This patch drops the 'else' statement in the redis.conf template so by
default the cluster-enabled setting won't appear in the configuration
file. It will fix Redis < 3 support and when running Redis >=3, it will
just not activate clustering.
This change is compatible with both versions.
[1] 4fb33b9
[2] http://stackoverflow.com/questions/27835659/redis-cluster-support-in-redis-2-8-19