-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does this work with nginx 1.20.2? #227
Comments
Yes. |
wow ... to be honest i didnt expect a response ! Thanks for the quick response . I'm stuck with this error Any help would be much appricated |
Did you have nginx_upstream_check_module? --add-module=../nginx_upstream_check_module-master |
yes Is that expected ? |
You probably did not patch https://github.com/yaoweibin/nginx_upstream_check_module/blob/master/check_1.20.1%2B.patch#L236 |
i did and hence got the active health check working.. the issue now is for Nginx-module-vts module still flags all upstream servers up in its status page |
Did you configure the check? |
@prabumohan --- ngx_http_vhost_traffic_status_display_json.c 2021-01-25 00:21:14.610002559 +0900
+++ ngx_http_vhost_traffic_status_display_json.c.o 2022-09-05 23:43:21.015685286 +0900
@@ -10,10 +10,6 @@
#include "ngx_http_vhost_traffic_status_display_json.h"
#include "ngx_http_vhost_traffic_status_display.h"
-#if (NGX_HTTP_UPSTREAM_CHECK)
-#include "ngx_http_upstream_check_module.h"
-#endif
-
u_char *
ngx_http_vhost_traffic_status_display_set_main(ngx_http_request_t *r,
@@ -582,17 +578,7 @@ ngx_http_vhost_traffic_status_display_se
usn.max_fails = peer->max_fails;
usn.fail_timeout = peer->fail_timeout;
usn.backup = 0;
-#if (NGX_HTTP_UPSTREAM_CHECK)
- if (ngx_http_upstream_check_peer_down(peer->check_index)) {
- usn.down = 1;
-
- } else {
- usn.down = 0;
- }
-#else
usn.down = (peer->fails >= peer->max_fails || peer->down);
-#endif
-
#if nginx_version > 1007001
usn.name = peer->name;
#endif |
@prabumohan So that a lot of people confuse what to do and not to recognize the necessary of the upstream status collect module such as To check the copatiblity of it and this module, we also consider that it should prepare the procedure how to setup with it in this README and the combined test case in this CI before too long. |
No description provided.
The text was updated successfully, but these errors were encountered: