Merge pull request #562

Fix #548: Converting html images fails if the image refers to an emoji without a shortcut
vsch · Apr 30, 2023 · d58e370 · d58e370
2 parents e51f246 + c31cc03
commit d58e370
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/...n/java/com/vladsch/flexmark/html2md/converter/internal/HtmlConverterCoreNodeRenderer.java b/...n/java/com/vladsch/flexmark/html2md/converter/internal/HtmlConverterCoreNodeRenderer.java
@@ -658,7 +658,7 @@ private void processImg(Element element, HtmlNodeConverterContext context, HtmlM
                 }
             }
 
-            if (emoji != null) {
+            if (emoji != null && emoji.shortcut != null) {
                 out.append(':').append(emoji.shortcut).append(':');
             } else {
                 LinkConversion conv = myHtmlConverterOptions.extInlineImage;

diff --git a/flexmark-html2md-converter/src/test/resources/html_converter_issue_spec.md b/flexmark-html2md-converter/src/test/resources/html_converter_issue_spec.md
@@ -1911,3 +1911,13 @@ Issue [#357, HTML to markdown and removed nested list]
 [#353, How to self modify parse method when htmltomarkdown]: https://github.com/vsch/flexmark-java/issues/353
 [#357, HTML to markdown and removed nested list]: https://github.com/vsch/flexmark-java/issues/357
 
+
+## Issue 548
+
+Issue #548 , Images with emoji-filenames break the emoji handling code if they have no corresponding shortcut
+
+```````````````````````````````` example Issue 548: 1
+![](1f9a0.png)
+.
+<img src="1f9a0.png" />
+````````````````````````````````