Use header and footer text from plist file

[tamastimar]

CocoaPods provides a way to customize header and footer text in generated acknowledgements files (see: Using Acknowledgements). VTAcknowledgementsViewController does not take account of that. This PR tries to solve that.

When I've customized the footer in my Podfile it was not reflected in the table view footer. I didn't understand why since this pod seemed to use footer text from plist file (both are "Generated by..."). So I think it can be misunderstood.

Here is my proposal:

• there should be a footerText property in pair with headerText.
• both of them should use the texts in plist as default value.

In this way users can customize header and footer either in podfile or code.

[vtourraine]

Well, I simply wasn’t aware that it was customizable. Good catch! This isn’t mentioned on the Podfile reference page, but if it works, I guess it makes sense to support it.

I’ll need a bit more time to review this PR, but I’ll definitely take care of it soon. Thanks for the contribution 👍

[vtourraine]

Alright, the PR is merged. I’ve made a couple of changes.

What I didn’t realized before is that, yes, by default all acknowledgements file have a header: This application makes use of the following third party libraries:. I want to keep this pod simple and good looking, and I’m not sure if this line is necessary. Just like we localized the default footer text (Generated by CocoaPods - http://cocoapods.org), supporting the default header would mean that we’d have to localize it too (currently 11 languages).

So this is what it looks like now:

It looks nice, but maybe simpler is better by default. And you can always customize the header value if you really want to show something.