Update podspec iOS version to 9.1 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…target of the xcodeproject
vtourraine
changed the title
|
Hi! Thanks for the pull request. You’re right that there’s a disconnection between the project deployment target and the podspec minimum version, but I still want to keep supporting older iOS versions as much as possible. So I’ll set the deployment target to 8.0, which is the minimum version supported by the latest version of Xcode. If someone needs to support earlier iOS versions, please checkout an earlier version of VTAcknowledgementsViewController. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated podspec iOS version to 9.1, which is the current deployment target of the xcodeproject.
When installing from Cocoapods in other projects, it was compiled for iOS 5, so the library has many warnings due to unavailable methods being used in earlier versions.
Since the Xcode project is already set to iOS 9.1, this is indeed a very small change.