Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): don't render comments in TransitionGroup #11961

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Conversation

edison1105
Copy link
Member

close #11958

Copy link

pkg-pr-new bot commented Sep 18, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11961

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11961

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11961

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11961

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11961

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11961

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11961

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11961

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11961

vue

pnpm add https://pkg.pr.new/vue@11961

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11961

commit: c788bd3

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB 37.9 kB 34.1 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.8 kB 18.8 kB 17.2 kB
createApp 55.4 kB 21.3 kB 19.4 kB
createSSRApp 59.4 kB 23 kB 21 kB
defineCustomElement 60.2 kB 22.9 kB 20.9 kB
overall 69.1 kB 26.4 kB 24 kB

@edison1105 edison1105 added 🐞 bug Something isn't working ready to merge The PR is ready to be merged. scope: transition labels Sep 18, 2024
@yyx990803 yyx990803 merged commit a2f6ede into main Sep 20, 2024
15 checks passed
@yyx990803 yyx990803 deleted the edison/fix/11958 branch September 20, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working ready to merge The PR is ready to be merged. scope: transition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TransitionGroup hydration mismatch (caused by comment)
2 participants