Skip to content

Commit

Permalink
feat: implement require-explicit-slots (#2325)
Browse files Browse the repository at this point in the history
Co-authored-by: Mussin Benarbia <mussin.benarbia@gmail.com>
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
  • Loading branch information
3 people committed Jan 16, 2024
1 parent e7b87ff commit 634f38d
Show file tree
Hide file tree
Showing 4 changed files with 466 additions and 0 deletions.
1 change: 1 addition & 0 deletions docs/rules/require-explicit-emits.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ export default {
## :couple: Related Rules

- [vue/no-unused-emit-declarations](./no-unused-emit-declarations.md)
- [vue/require-explicit-slots](./require-explicit-slots.md)

## :books: Further Reading

Expand Down
68 changes: 68 additions & 0 deletions docs/rules/require-explicit-slots.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
---
pageClass: rule-details
sidebarDepth: 0
title: vue/require-explicit-slots
description: require slots to be explicitly defined with defineSlots
---

# vue/require-explicit-slots

> require slots to be explicitly defined
- :exclamation: <badge text="This rule has not been released yet." vertical="middle" type="error"> ***This rule has not been released yet.*** </badge>

## :book: Rule Details

This rule enforces all slots used in the template to be defined once either in the `script setup` block with the [`defineSlots`](https://vuejs.org/api/sfc-script-setup.html) macro, or with the [`slots property`](https://vuejs.org/api/options-rendering.html#slots) in the Options API.

<eslint-code-block :rules="{'vue/require-explicit-slots': ['error']}">

```vue
<template>
<div>
<!-- ✓ GOOD -->
<slot />
<slot name="foo" />
<!-- ✗ BAD -->
<slot name="bar" />
</div>
</template>
<script setup lang="ts">
defineSlots<{
default(props: { msg: string }): any
foo(props: { msg: string }): any
}>()
</script>
```

</eslint-code-block>

<eslint-code-block :rules="{'vue/require-explicit-slots': ['error']}">

```vue
<template>
<div>
<!-- ✓ GOOD -->
<slot />
<slot name="foo" />
<!-- ✗ BAD -->
<slot name="bar" />
</div>
</template>
<script lang="ts">
import { SlotsType } from 'vue'
defineComponent({
slots: Object as SlotsType<{
default: { msg: string }
foo: { msg: string }
}>
})
</script>
```

</eslint-code-block>

## :wrench: Options

Nothing.
128 changes: 128 additions & 0 deletions lib/rules/require-explicit-slots.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
/**
* @author Mussin Benarbia
* See LICENSE file in root directory for full license.
*/
'use strict'

const utils = require('../utils')

/**
* @typedef {import('@typescript-eslint/types').TSESTree.TypeNode} TypeNode
*/

module.exports = {
meta: {
type: 'problem',
docs: {
description: 'require slots to be explicitly defined',
categories: undefined,
url: 'https://eslint.vuejs.org/rules/require-explicit-slots.html'
},
fixable: null,
schema: [],
messages: {
requireExplicitSlots: 'Slots must be explicitly defined.',
alreadyDefinedSlot: 'Slot {{slotName}} is already defined.'
}
},
/** @param {RuleContext} context */
create(context) {
const sourceCode = context.getSourceCode()
const documentFragment =
sourceCode.parserServices.getDocumentFragment &&
sourceCode.parserServices.getDocumentFragment()
if (!documentFragment) {
return {}
}
const scripts = documentFragment.children.filter(
(element) => utils.isVElement(element) && element.name === 'script'
)
if (scripts.every((script) => !utils.hasAttribute(script, 'lang', 'ts'))) {
return {}
}
const slotsDefined = new Set()

return utils.compositingVisitors(
utils.defineScriptSetupVisitor(context, {
onDefineSlotsEnter(node) {
const typeArguments =
'typeArguments' in node ? node.typeArguments : node.typeParameters
const param = /** @type {TypeNode|undefined} */ (
typeArguments?.params[0]
)
if (!param) return

if (param.type === 'TSTypeLiteral') {
for (const memberNode of param.members) {
const slotName = memberNode.key.name
if (slotsDefined.has(slotName)) {
context.report({
node: memberNode,
messageId: 'alreadyDefinedSlot',
data: {
slotName
}
})
} else {
slotsDefined.add(slotName)
}
}
}
}
}),
utils.executeOnVue(context, (obj) => {
const slotsProperty = utils.findProperty(obj, 'slots')
if (!slotsProperty) return

const slotsTypeHelper =
slotsProperty.value.typeAnnotation?.typeName.name === 'SlotsType' &&
slotsProperty.value.typeAnnotation
if (!slotsTypeHelper) return

const typeArguments =
'typeArguments' in slotsTypeHelper
? slotsTypeHelper.typeArguments
: slotsTypeHelper.typeParameters
const param = /** @type {TypeNode|undefined} */ (
typeArguments?.params[0]
)
if (!param) return

if (param.type === 'TSTypeLiteral') {
for (const memberNode of param.members) {
const slotName = memberNode.key.name
if (slotsDefined.has(slotName)) {
context.report({
node: memberNode,
messageId: 'alreadyDefinedSlot',
data: {
slotName
}
})
} else {
slotsDefined.add(slotName)
}
}
}
}),
utils.defineTemplateBodyVisitor(context, {
"VElement[name='slot']"(node) {
let slotName = 'default'

const slotNameAttr = utils.getAttribute(node, 'name')

if (slotNameAttr) {
slotName = slotNameAttr.value.value
}

if (!slotsDefined.has(slotName)) {
context.report({
node,
messageId: 'requireExplicitSlots'
})
}
}
})
)
}
}
Loading

0 comments on commit 634f38d

Please sign in to comment.