Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix siblings and interleaving issues reported in #2342 #2348

Merged
merged 13 commits into from
Jul 13, 2024
Merged

Fix siblings and interleaving issues reported in #2342 #2348

merged 13 commits into from
Jul 13, 2024

Conversation

felipemelendez
Copy link
Contributor

@felipemelendez felipemelendez commented Dec 7, 2023 •
edited
Loading

This PR addresses the bugs reported in #2342

And added tests

@felipemelendez
Copy link
Contributor Author

Hi @FloEdelmann, thank you for reporting #2342, I have hopefully addressed those here, please let me know if I missed something.

@FloEdelmann FloEdelmann linked an issue Dec 7, 2023 that may be closed by this pull request
vue/v-if-else-key false-positives and false-negatives #2342
Closed
2 tasks
FloEdelmann
FloEdelmann reviewed Dec 8, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not yet looked into your implementation, but I noticed one wrong test case.

tests/lib/rules/v-if-else-key.js Outdated Show resolved Hide resolved
FloEdelmann
FloEdelmann reviewed Dec 13, 2023
View reviewed changes
lib/rules/v-if-else-key.js Outdated Show resolved Hide resolved
lib/rules/v-if-else-key.js Outdated Show resolved Hide resolved
lib/rules/v-if-else-key.js Outdated Show resolved Hide resolved
@FloEdelmann
Copy link
Member

@felipemelendez Are you still interested in fixing this?

@felipemelendez
Copy link
Contributor Author

@felipemelendez Are you still interested in fixing this?

Yes! Sorry for the delay, I had a family emergency at the start of the year, so I've been distracted to say the least; I'll get back on this soon!

@FloEdelmann
Copy link
Member

No worries, there's more important stuff in life than coding 🙂

FloEdelmann
FloEdelmann reviewed Jul 8, 2024
View reviewed changes
lib/rules/v-if-else-key.js Outdated Show resolved Hide resolved
lib/rules/v-if-else-key.js Show resolved Hide resolved
lib/rules/v-if-else-key.js Outdated Show resolved Hide resolved
tests/lib/rules/v-if-else-key.js Outdated Show resolved Hide resolved
FloEdelmann
FloEdelmann approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙂

ota-meshi
ota-meshi approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 79e13d1 into vuejs:master Jul 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue/v-if-else-key false-positives and false-negatives
3 participants
@felipemelendez @FloEdelmann @ota-meshi