Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Vue APIs from auto imports #2422

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Conversation

antfu
Copy link
Member

@antfu antfu commented Mar 11, 2024

This PR makes rules able to recognize global ref computed variables, when they are presented in the globals option in ESLint.

This would require presets to be configured properly, for Nuxt I will configure https://github.com/antfu/nuxt-module-eslint-config and for the rest I will update my eslint config: https://github.com/antfu/eslint-config

fix #1969

@antfu antfu marked this pull request as draft March 11, 2024 12:10
@antfu antfu changed the title wip: support detectAutoImport option featsupport detectAutoImport option Mar 11, 2024
@antfu antfu changed the title featsupport detectAutoImport option feat: support Vue APIs from auto imports Mar 11, 2024
@antfu antfu marked this pull request as ready for review March 11, 2024 13:04
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, apart from one small docs change. Thanks for contributing!

docs/user-guide/index.md Outdated Show resolved Hide resolved
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much!

@ota-meshi ota-meshi merged commit 3abc04c into master Mar 11, 2024
17 checks passed
@ota-meshi ota-meshi deleted the feat/detect-auto-import branch March 11, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuxt 3: auto imported ref will not trigger vue/no-ref-as-operand warning
3 participants