-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Included image filename contains space will make build fail #2596
Labels
bug: pending triage
Maybe a bug, waiting for confirmation
Comments
Duplicate of #573 |
Jeff-Tian
added a commit
to Jeff-Tian/core
that referenced
this issue
Jul 10, 2023
yyx990803
pushed a commit
to vuejs/core
that referenced
this issue
Oct 20, 2023
By decoding them before generating them as JavaScript import paths fix vuejs/vitepress#2596 fix vuejs/vitepress#573
yyx990803
pushed a commit
to vuejs/core
that referenced
this issue
Oct 21, 2023
By decoding them before generating them as JavaScript import paths fix vuejs/vitepress#2596 fix vuejs/vitepress#573
lumozx
pushed a commit
to lumozx/core
that referenced
this issue
Oct 21, 2023
By decoding them before generating them as JavaScript import paths fix vuejs/vitepress#2596 fix vuejs/vitepress#573
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
In dev mode, both image filenames contain space or not will serve fine:
But the build will fail when met the image assets whose filename contains space:
Reproduction
See https://stackblitz.com/edit/vite-upxxuh?file=docs%2Fbook%2Fresources%2Ftest%20(1).svg,docs%2Findex.md,docs%2Fbook%2Fresources%2Ftest.svg,
add a image filename contains space and build.
Expected behavior
Build should succeed.
Ideally should
decodeURIComponent
when converting![](image%20(1).png]
to code.So the converted code should be like
import image from "image (1).png"
instead ofimport image from "image%20(1).png"
.System Info
Additional context
No response
Validations
The text was updated successfully, but these errors were encountered: