Case Sensitive Option for Routes #1214

[smitt04]

Added both a caseSenstive and pathToRegexpOptions property on RouteConfig. The caseSensitive property will override and add to pathToRegexpOptions which defaults to {}.

Along with that RouteRecord gets pathToRegexpOptions that comes from RouteConfig

[posva]

Could you add some test case, please?
I have one concern, it's about the route cache: if we allow overwriting routes, changing the caseSensitive option wouldn't do anything. We can also point it out in docs though, I don't see an actual use case for that but it's a gotcha 😆

[smitt04]

I was looking at where to add tests. I couldn't find any similar tests in unit and not sure where to add in e2e, didn't see any redirect tests (which is where we were having the problem). I did add it to the examples though. And before my code was working the examples broke. I would be happy adding other tests if you could point me in the right direction.

[smitt04]

@posva I have added some tests, let me know if this is good.

[smitt04]

Do we have an eta for this?

[posva]

Sorry for the delay 😅

[posva]

I'm looking into this again, there are some conflicts I'm fixing. I should get a working pr soon

[posva]

Right now, the global option doesn' work. I'm looking at that

[posva]

The things that I'm not sure yet:

• Should we remove the caseSensitive option?
  • if yes, keeping only the pathToRegexOptions restrict us to using that lib
  • if no, we'd have 2 ways of setting the case sensitive option. Why the case is aliased while the others aren't?
• The naming of pathToRegexOptions is a bit too long and very technical, maybe pathToRegex is enough but it's unclear. regexOptions or pathOptions are other alternatives

[posva]

Note to myself, do not forget to close #1214 when merging

[posva]

ping @yyx990803 tldr: #1215 (comment)

[rivieiraa]

When will this be merged ?

[dotBits]

I'm waiting for this merge as well. Is important to have consistency between indexed URLs with trailing slashes, otherwise there will be duplicate URLs for crawlers

[MachinisteWeb]

Champagne ! (that resolve also my point: #1443)

Thx guys.

[MachinisteWeb]

Where is the pathToRegexpOptions documentation ? Or maybe an example ?

For example the { strict: true } mode not work as expected. It's allows only url not ending with / to work. And it's not work with defaultpage.

I have only : https://router.vuejs.org/en/api/options.html#routes that indicate the property exist, but I do not have any example or detail. Where I know ``{ strict: true }` exist and what is it's true purpose ?

[rivieiraa]

@haeresis

Where is the pathToRegexpOptions documentation ?

pathToRegexp github page
Try this.

[MachinisteWeb]

I will add this information to the vue-router doc. Thx @rivieiraa !

[rivieiraa]

It's pathToRegex(p)Options

strict When false the trailing slash is optional. (default: false)

It is correct to use pathToRegexpOptions: { strict: true }

[MachinisteWeb]

So I have an issue. If I set pathToRegexpOptions: { strict: true }, only page « without » trailing work. And I expected page only « with » that's work...

On my server I create:

/ and /test/ for exemple

/ <= OK
/test/ <= OK
/test <= NOK

and with vue-router, by default it's that:

/ <= OK
/test/ <= OK
/test <= OK

With usage of pathToRegexpOptions: { strict: true } I expected this

/ <= OK
/test/ <= OK
/test <= NOK

But what I have is that

With usage of pathToRegexpOptions: { strict: true }

/ <= OK
/test/ <= NOK
/test <= OK

...

Normal?

[rivieiraa]

I understand your situation.

that resolve also my point: #1443

Nope, it doesn't actually. This particular pull request was about case sensitivity but also involved another pathToRegexp options as they all passed together.

[MachinisteWeb]

So, if I correctly understand,
you think it's not normal and
there is another pull request dedicated to pathToRegexp .

You know the link to this pull request?

[rivieiraa]

Sure, i believe there must be an option to strict trailing slashes more clearly (to make slash mandatory or to deprecate it). But as long as vue router uses pathToRegexp it's a problem of third party software and i'm not sure if it could be done anyways.
No, there is no PR dedicated to trailing slash, but there is an issue you pointed to earlier #1443

[MachinisteWeb]

I will ask to re-open it so. Thx a lot !

[posva]

@haeresis I created an issue on the repo instead: pillarjs/path-to-regexp#112 Feel free to share your thoughts there

[rivieiraa]

@posva
hello! what is the difference between caseSensitive and pathToRegexpOptions: { sensitive: true } options?

[posva]

the same, it's just that caseSensitive seems like a very common use case

[adamreisnz]

Has this been removed? pathToRegexpOptions: {strict: true} doesn't seem to do anything, still getting URL's with a trailing slash.