fix target _blank when anchor has children #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couple of days ago, we have faced an issue with out non-SPA project: Once you add a child element to a ``<router-link>`` with ``target="_blank"`` attribute, it wouldn't fire on a new tab. check this fiddle: https://jsfiddle.net/asynchronous/dnLs1dm4/10/ I've changed ``gaurdEvent`` method in ``link`` component so it could fix this issue.
|
What browser are you facing the issue? It's working properly on Chrome |
|
@posva we've checked on chrome and firefox (both ubuntu and windows). are you sure you're clicking on span link ? |
|
yes, both links behave the same (chrome 57) |
|
@posva anchor with child is not opening in new tab for me too.
|
|
I see, it doesn't work on firefox. |
|
Nah man, same thing on Chrome ... even multiple PCs :/ |
|
@posva yes currentTarget fixed that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of days ago, we have faced an issue with out non-SPA project:
Once you add a child element to a
<router-link>withtarget="_blank"attribute, it wouldn't fire on a new tab. check this fiddle:https://jsfiddle.net/asynchronous/dnLs1dm4/10/
I've changed
gaurdEventmethod inlinkcomponent so it could fix this issue.