Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make callback of next in beforeRouterEnter more consistent #2738

Merged
merged 4 commits into from
May 9, 2019

Conversation

zrh122
Copy link
Contributor

@zrh122 zrh122 commented Apr 24, 2019

Improve #2728. Make callback of next to be called as same order as beforeRouterEnter.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks! Could you add a test for this? An e2e test should do it. You could check that a string grows to a specific value (to check the order is right) but if you have a better idea, that's good too!

@zrh122
Copy link
Contributor Author

zrh122 commented Apr 25, 2019

@posva , I will add a test for it. I intend to add the test in navigation guards, but I find that the test code in this file never execute because it just return when find use PhantomJS, and currently only use PhantomJS.

@posva
Copy link
Member

posva commented Apr 27, 2019

I see, I will take a look next week then and keep you posted. Thanks for #2749 BTW!

@posva posva changed the title chore: make callback of next in beforeRouterEnter more consistent fix: make callback of next in beforeRouterEnter more consistent May 8, 2019
@posva
Copy link
Member

posva commented May 9, 2019

As you said, it does fix #2761 too, I added a test for that. I will add another test for the other case too

@zrh122
Copy link
Contributor Author

zrh122 commented May 9, 2019

As you said, it does fix #2761 too, I added a test for that. I will add another test for the other case too

Thx.

@posva posva merged commit 8ac478f into vuejs:dev May 9, 2019
@vue-bot
Copy link

vue-bot commented May 9, 2019

Hey @zrh122, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@zrh122 zrh122 deleted the improve-cb-of-next branch May 10, 2019 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants