Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIP: move builtin interfaces to ethereum.ercs #3675

Closed
charles-cooper opened this issue Nov 23, 2023 · 3 comments
Closed

VIP: move builtin interfaces to ethereum.ercs #3675

charles-cooper opened this issue Nov 23, 2023 · 3 comments
Milestone
v0.4.0

Comments

@charles-cooper
Copy link
Member

Simple Summary

move builtin interfaces like ERC20 to ethereum.ercs instead of vyper.interfaces

Motivation

ERC20 et al are clearly ethereum-specific (ERC in fact standing for "Ethereum Request for Comment"), not something related to vyper- the language.

Specification

per title

Backwards Compatibility

breaks backwards compatibility. we could have a deprecation period for the 0.4.x series where import ERC20 from vyper.interfaces is deprecated but still works; meanwhile the new and recommended way is import ERC20 from ethereum.ercs.

References

loosely related to #2431 and #2814

Copyright

Copyright and related rights waived via CC0
@anewt95

This comment was marked as duplicate.

Sign in to view
@charles-cooper charles-cooper added this to the v0.4.0 milestone Jan 12, 2024
@ControlCplusControlV
Copy link
Contributor

Wait, should builtins/interfaces/ be made to /builtins/ercs/ or /builtins/ethereum/ercs/?

ControlCplusControlV added a commit to ControlCplusControlV/vyper that referenced this issue Jan 20, 2024
@ControlCplusControlV
fixed issue vyperlang#3675
36dcab9
Merged
@charles-cooper
Copy link
Member Author

done in #3741

@charles-cooper charles-cooper mentioned this issue Feb 10, 2024
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

No branches or pull requests
3 participants
@charles-cooper @ControlCplusControlV @anewt95