Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HashMap index checks when the subscript is folded #3984

Closed
charles-cooper opened this issue Apr 30, 2024 · 0 comments · Fixed by #4007
Closed

HashMap index checks when the subscript is folded #3984

charles-cooper opened this issue Apr 30, 2024 · 0 comments · Fixed by #4007
Labels
bug - type 1 bug which results in incorrect codegen
Milestone
v0.4.0

Comments

@charles-cooper
Copy link
Member

per @Leminkay

Version Information

vyper Version (output of vyper --version): 6f09e29

Issue description and/or POC

m: HashMap[uint256, uint256]

@external
def foo():
   self.m[0-1] = 2

Successfully compiles

introduced in #3669, related bug was fixed in #3924 (but this bug was not fixed)
@charles-cooper charles-cooper added the bug - type 1 bug which results in incorrect codegen label May 6, 2024
@charles-cooper charles-cooper added this to the v0.4.0 milestone May 6, 2024
DanielSchiavini added a commit to DanielSchiavini/vyper that referenced this issue May 7, 2024
@DanielSchiavini
fix[codegen]: index checks when the subscript is folded
c816a0d 
Fixes vyperlang#3984
@DanielSchiavini DanielSchiavini mentioned this issue May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug - type 1 bug which results in incorrect codegen
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

fix[lang]: typecheck hashmap indexes with folding DanielSchiavini/vyper
1 participant
@charles-cooper