-
-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow referencing events from interfaces #2852
fix: allow referencing events from interfaces #2852
Conversation
allow the following: ``` import bar as Bar @external def foo(): log Bar.SomeEvent(...) ```
Codecov Report
@@ Coverage Diff @@
## master #2852 +/- ##
===========================================
- Coverage 87.65% 52.00% -35.65%
===========================================
Files 94 94
Lines 10179 10181 +2
Branches 2503 2453 -50
===========================================
- Hits 8922 5295 -3627
- Misses 791 4275 +3484
- Partials 466 611 +145
Continue to review full report at Codecov.
|
since they can be imported now
so this is a bit more complicated, since i removed the requirement to implement all events in an interface:
but it seems wasteful to force copy-paste. maybe we should have some kind of |
meeting notes: export any events that are logged in a contract |
superseded by #3663 |
allow the following:
What I did
How I did it
allow interfaces to resolve to events in
get_type_from_node
for interface members.How to verify it
see usage in ERC20.vy and ERC721.vy
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture