Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop evm versions through istanbul #3470

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented May 30, 2023

What I did

drop pre-istanbul versions. actually, per #3365, we could drop everything pre-paris, but brownie still defaults to evm_version: istanbul, and i'm not sure we want to break that. (actually, maybe we do want to drop istanbul because then brownie users would stop trying to verify contracts compiled for istanbul, and would instead explicitly set the evm version to something more recent).

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper changed the title chore: drop old evm versions chore: drop evm versions through istanbul May 30, 2023
@charles-cooper charles-cooper marked this pull request as ready for review May 30, 2023 20:19
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

Merging #3470 (258b6a6) into master (66b9670) will decrease coverage by 36.15%.
The diff coverage is 72.72%.

❗ Current head 258b6a6 differs from pull request most recent head c5c4f7d. Consider uploading reports for the commit c5c4f7d to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           master    #3470       +/-   ##
===========================================
- Coverage   89.30%   53.16%   -36.15%     
===========================================
  Files          84       84               
  Lines       10792    10778       -14     
  Branches     2461     2456        -5     
===========================================
- Hits         9638     5730     -3908     
- Misses        756     4534     +3778     
- Partials      398      514      +116     
Impacted Files Coverage Δ
vyper/cli/vyper_compile.py 17.64% <ø> (-50.74%) ⬇️
vyper/cli/vyper_json.py 9.31% <0.00%> (-69.32%) ⬇️
vyper/codegen/expr.py 38.69% <ø> (-49.01%) ⬇️
vyper/codegen/external_call.py 18.91% <ø> (-78.38%) ⬇️
vyper/codegen/arithmetic.py 65.78% <50.00%> (-20.20%) ⬇️
vyper/codegen/core.py 51.34% <100.00%> (-35.41%) ⬇️
vyper/evm/opcodes.py 90.69% <100.00%> (-9.31%) ⬇️
vyper/ir/optimizer.py 77.77% <100.00%> (-20.43%) ⬇️

... and 60 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

drop pre-istanbul versions. per VIP-3365, we could drop through paris,
but since this is the first time starting to enforce this policy, we
don't want to drop too many versions at once.
@charles-cooper charles-cooper enabled auto-merge (squash) June 1, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants