refactor: builtin functions inherit from VyperType
#3559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3559 +/- ##
==========================================
+ Coverage 89.61% 90.21% +0.60%
==========================================
Files 80 79 -1
Lines 11343 11257 -86
Branches 2553 2544 -9
==========================================
- Hits 10165 10156 -9
+ Misses 791 713 -78
- Partials 387 388 +1 ☔ View full report in Codecov by Sentry. |
tserg
commented
Aug 18, 2023
vyper/semantics/types/function.py
Outdated
| # note special meaning for -1 in validate_call_args API | ||
| expect_num_args = (num_args, -1) | ||
|
|
||
| validate_call_args(node, expect_num_args, list(self._kwargs.keys())) |
There was a problem hiding this comment.
Last argument should be a list of names for valid keyword arguments. Previously, it was a dictionary of KwargSettings.
tserg
commented
Aug 18, 2023
tserg
commented
Aug 18, 2023
This reverts commit 9fbba35.
charles-cooper
changed the title
VyperType
| @@ -98,22 +98,22 @@ | |||
| ) | |||
|
|
|||
| from ._convert import convert | |||
| from ._signatures import BuiltinFunction, process_inputs | |||
| from ._signatures import BuiltinFunctionT, process_inputs | |||
Check notice
Code scanning / CodeQL
Cyclic import Note
charles-cooper
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Builtin functions are currently the remaining types that are not a "VyperType". This PR resolves this inconsistency by making builtin functions inherit from
VyperType.How I did it
Move code around.
How to verify it
See tests
Commit message
Description for the changelog
Make builtin functions vyper types
Cute Animal Picture