Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad assertion in expr.py #3758

Merged

Conversation

charles-cooper
Copy link
Member

in addition to structs and interfaces, some builtins can also be skipped by the constant folder.

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

in addition to structs and interfaces, some builtins can also be skipped
by the constant folder.
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db8ac3c) 84.78% compared to head (e58b78c) 84.78%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3758      +/-   ##
==========================================
- Coverage   84.78%   84.78%   -0.01%     
==========================================
  Files          92       92              
  Lines       13141    13140       -1     
  Branches     2930     2930              
==========================================
- Hits        11142    11141       -1     
  Misses       1535     1535              
  Partials      464      464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper merged commit f7f67d0 into vyperlang:master Feb 5, 2024
84 checks passed
@charles-cooper charles-cooper deleted the fix/constant_folding branch February 5, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants