Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run mypy as part of lint rule in Makefile #3771

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

charles-cooper
Copy link
Member

and remove the separate mypy rule. this makes the development workflow a bit faster

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

and remove the separate mypy rule. this makes the development workflow a
bit faster
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ccacb3) 84.97% compared to head (b9f98fd) 84.94%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3771      +/-   ##
==========================================
- Coverage   84.97%   84.94%   -0.03%     
==========================================
  Files          92       92              
  Lines       13594    13594              
  Branches     3060     3060              
==========================================
- Hits        11552    11548       -4     
- Misses       1556     1560       +4     
  Partials      486      486              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper merged commit 37ef8f4 into vyperlang:master Feb 11, 2024
84 checks passed
@charles-cooper charles-cooper deleted the chore/make-lint branch February 11, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants