Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve warnings, refactor vyper_warn() #3800

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Feb 21, 2024

What I did

add source information to vyper_warn() to give more helpful warnings

How I did it

How to verify it

write some vyper code with old-style structs, like

    p: Proposal = Proposal({x: 1, y: 2})

see that the warning includes the source location after this commit.

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@@ -9,7 +9,7 @@
import warnings
from typing import Generic, List, TypeVar, Union

from vyper.exceptions import CompilerPanic, DecimalOverrideException, InvalidLiteral
from vyper.exceptions import CompilerPanic, DecimalOverrideException, InvalidLiteral, VyperException

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
vyper.exceptions
begins an import cycle.
@charles-cooper charles-cooper changed the title feat: improve warnings refactor vyper_warn() feat: improve warnings, refactor vyper_warn() Feb 22, 2024
@charles-cooper charles-cooper merged commit 26eaa8a into vyperlang:master Feb 22, 2024
84 checks passed
@charles-cooper charles-cooper deleted the fix/dict-warnings branch February 22, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants