feat[tool]: delay global constraint check #3810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move the global constraint to later in compilation pipeline, so that you can get a "partial compilation" library modules with `-f annotated_ast`. these library modules may declare `uses: X`, without initializing `X. this is intended for third-party tools like IDEs, which may want to get validation that a module will compile, even if it can't generate bytecode (be a compilation target)
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3810 +/- ##
==========================================
- Coverage 85.18% 85.07% -0.11%
==========================================
Files 92 92
Lines 13908 13914 +6
Branches 3116 3118 +2
==========================================
- Hits 11847 11838 -9
- Misses 1567 1581 +14
- Partials 494 495 +1 ☔ View full report in Codecov by Sentry. |
charles-cooper
changed the title
charles-cooper
requested review from
fubuloubu,
tserg,
cyberthirst and
pcaversaccio
tserg
approved these changes
Feb 26, 2024
pcaversaccio
approved these changes
Feb 26, 2024
cyberthirst
approved these changes
Feb 27, 2024
fubuloubu
approved these changes
Feb 27, 2024
vyper/semantics/analysis/module.py
Outdated
| @@ -54,8 +54,8 @@ | |||
| def validate_module_semantics_r( | |||
There was a problem hiding this comment.
why _r? seems like unexplained codebase definition to use these as external API, and _r should just be expanded
There was a problem hiding this comment.
_r is the convention for a lot of recursive functions. idk that it's really an external api, i can add a wrapper though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture