fix[codegen]: overflow check in slice()
#3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-cooper
changed the title
slice()
|
actually i forgot to put this back into draft since i haven't had time to look into the test failures yet |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3818 +/- ##
==========================================
- Coverage 86.33% 86.05% -0.28%
==========================================
Files 92 92
Lines 14010 14024 +14
Branches 3077 3081 +4
==========================================
- Hits 12096 12069 -27
- Misses 1484 1523 +39
- Partials 430 432 +2 ☔ View full report in Codecov by Sentry. |
trocher
reviewed
Mar 18, 2024
electriclilies
pushed a commit
to electriclilies/vyper
that referenced
this pull request
Apr 27, 2024
the buffer out-of-bounds check in slice() does not take into account the possibility for arithmetic overflow. this commit fixes the oob check by adding an overflow check. it also refactors the slice check into a helper function, and adds relevant tests. patches GHSA-9x7f-gwxq-6f2c. --------- Co-authored-by: cyberthirst <cyberthirst.eth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fix #3756
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture