Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[ir]: add eval_once sanity fences to more builtins #3835

Merged

Conversation

charles-cooper
Copy link
Member

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.12%. Comparing base (45c6b6a) to head (0f3ebab).
Report is 5 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3835      +/-   ##
==========================================
+ Coverage   85.23%   86.12%   +0.88%     
==========================================
  Files          92       92              
  Lines       13949    13921      -28     
  Branches     3130     3067      -63     
==========================================
+ Hits        11889    11989     +100     
+ Misses       1565     1495      -70     
+ Partials      495      437      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@trocher trocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core.STORE() could also use ensure_eval_once to be cleaner I guess

@charles-cooper
Copy link
Member Author

core.STORE() could also use ensure_eval_once to be cleaner I guess

0f3ebab

@charles-cooper charles-cooper merged commit 5825e12 into vyperlang:master Mar 8, 2024
84 checks passed
@charles-cooper charles-cooper deleted the fix/builtins-eval-once branch March 8, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants