Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[lang]!: change the signature of block.prevrandao #3879

Merged
merged 4 commits into from
Mar 23, 2024

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Mar 21, 2024

block.prevrandao is an opcode alias for difficulty. however, it returns a bytes object at the evm level (cf. for instance py-evm returns the value of block.mixhash). this commit changes the signature of block.prevrandao to be more consistent with the VM semantics.

What I did

How I did it

How to verify it

Commit message

`block.prevrandao` is an opcode alias for `difficulty`. however, it
returns a bytes object at the evm level (cf. for instance py-evm returns
the value of `block.mixhash`). this commit changes the signature of
`block.prevrandao` to be more consistent with the VM semantics.

also update PR title regex per conventional commit specification - add
optional `!` which indicates a breaking change

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

`block.prevrandao` is an opcode alias for `difficulty`. however, it
returns a bytes object at the evm level (cf. for instance py-evm returns
the value of `block.mixhash`). this commit changes the signature of
block.prevrandao to be more consistent with the VM semantics.
Copy link
Collaborator

@pcaversaccio pcaversaccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the docs return param here, otherwise LGTM.

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (b557e19) to head (03f3024).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3879      +/-   ##
==========================================
- Coverage   86.36%   86.33%   -0.04%     
==========================================
  Files          92       92              
  Lines       14024    14024              
  Branches     3081     3081              
==========================================
- Hits        12112    12107       -5     
- Misses       1484     1489       +5     
  Partials      428      428              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper
Copy link
Member Author

Update the docs return param here, otherwise LGTM.

done here 1c2243f

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as this goes out in a breaking change release

@fubuloubu fubuloubu changed the title feat[lang]: change the signature of block.prevrandao feat[lang]!: change the signature of block.prevrandao Mar 23, 2024
@charles-cooper charles-cooper enabled auto-merge (squash) March 23, 2024 14:30
@charles-cooper charles-cooper merged commit e48ff32 into vyperlang:master Mar 23, 2024
148 checks passed
electriclilies pushed a commit to electriclilies/vyper that referenced this pull request Apr 27, 2024
`block.prevrandao` is an opcode alias for `difficulty`. however, it
returns a bytes object at the evm level (cf. for instance py-evm returns
the value of `block.mixhash`). this commit changes the signature of
`block.prevrandao` to be more consistent with the VM semantics.

also update PR title regex per conventional commit specification - add
optional `!` which indicates a breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants