Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix[lang]: fix uses analysis for nonreentrant functions #3927

Merged
merged 12 commits into from
Apr 12, 2024
Merged

fix[lang]: fix uses analysis for nonreentrant functions #3927

merged 12 commits into from
Apr 12, 2024

Commits on Apr 9, 2024

  1. fix[lang]: fix uses analysis for nonreentrant functions 

    `uses` analysis ignores nonreentrant functions, even those (implicitly)
use state.

this commit adds checks both for internally (called) and external
(exported) modules
    @charles-cooper
    charles-cooper committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    471a864 View commit details
    Browse the repository at this point in the history

  2. refactor: factor out uses_state util 

    also, rename `validate_functions` to more accurate `analyze_functions`
    @charles-cooper
    charles-cooper committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    9db4bfb View commit details
    Browse the repository at this point in the history

  3. add syntax tests

    @charles-cooper
    charles-cooper committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    0cb0f93 View commit details
    Browse the repository at this point in the history

  4. add nonreentrant export test

    @charles-cooper
    charles-cooper committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    2f4525c View commit details
    Browse the repository at this point in the history

  5. add nonreentrant internal import test, move exported nonreentrant 

    function to new file
    @charles-cooper
    charles-cooper committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    8a69b83 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into fix/using-nonreentrant

    @charles-cooper
    charles-cooper committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    621c259 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Merge branch 'master' into fix/using-nonreentrant

    @charles-cooper
    charles-cooper committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f1a5aab View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. improve locality of exceptions thrown in check_module_uses

    @charles-cooper
    charles-cooper committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    f6d1c81 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. update error message

    @charles-cooper
    charles-cooper committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    eaa5988 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/using-nonreentrant

    @charles-cooper
    charles-cooper committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    f9e49cf View commit details
    Browse the repository at this point in the history

  3. update tests

    @charles-cooper
    charles-cooper committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    16ca98f View commit details
    Browse the repository at this point in the history

  4. add missing file

    @charles-cooper
    charles-cooper committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    d899831 View commit details
    Browse the repository at this point in the history