Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[venom]: fix list of volatile instructions #4065

Merged
merged 4 commits into from
May 30, 2024

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented May 30, 2024

What I did

How I did it

How to verify it

Commit message

`create` and `create2` are volatile instructions that were missing. the
other ones were already handled by the case for `output is None` in
`removed_unused_variables`.

misc:
- rename `volatile` to `is_volatile` for uniformity
- use `is_bb_terminator` instead of `in BB_TERMINATORS`

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

create and create2 are volatile instructions that were missing. the
other ones were already handled by the case for `output is None` in
removed_unused_variables.
@charles-cooper charles-cooper enabled auto-merge (squash) May 30, 2024 20:10
@charles-cooper charles-cooper merged commit 3371956 into vyperlang:master May 30, 2024
156 checks passed
@charles-cooper charles-cooper deleted the fix/volatile_list branch May 30, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants