Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nameFrom: heading to AccName text alt algorithm #229

Closed
wants to merge 1 commit into from

Conversation

cookiecrook
Copy link
Contributor

@cookiecrook cookiecrook commented Feb 3, 2024

Closes #182

Add nameFrom: heading to AccName text alt algorithm

Implementation


💥 Error: 502 Bad Gateway 💥

PR Preview failed to build. (Last tried on Feb 3, 2024, 7:32 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL

error code: 502

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@cookiecrook
Copy link
Contributor Author

Dependent upon related ARIA spec change:

Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

@MelSumner
Copy link
Contributor

I see that the related ARIA PR is approved, but do we have a merge order? Or is an approval enough to merge this one?

@cookiecrook
Copy link
Contributor Author

cookiecrook commented Feb 6, 2024

I think @spectranaut wants to wait for all this to happen:

At least that's my understanding from the outcome of:

But @spectranaut please correct me if I'm wrong.

scottaohara added a commit to w3c/html-aam that referenced this pull request Feb 6, 2024
closes #457

Related to the following:
- w3c/aria#1860
- w3c/accname#229 (this needs to be merged so the new links to 'accName: name from heading' will work
pkra pushed a commit to w3c/aria that referenced this pull request May 23, 2024
closes #457

Related to the following:
- #1860
- w3c/accname#229 (this needs to be merged so the new links to 'accName: name from heading' will work
@pkra pkra mentioned this pull request May 28, 2024
9 tasks
@MelSumner
Copy link
Contributor

This PR has been moved to the mono repo: w3c/aria#2209

@MelSumner MelSumner closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nameFrom: heading steps to computation after spec addition ARIA PR #1860 is reviewed.
3 participants