Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: add hasCrossSiteAncestor value to partitionKey in Cookies API #581

Merged
merged 56 commits into from
Sep 12, 2024
Merged

Proposal: add hasCrossSiteAncestor value to partitionKey in Cookies API #581

merged 56 commits into from
Sep 12, 2024

Commits on Mar 28, 2024

  1. Create hasCrossSiteAncestor.md 

    Add initial proposal
    @aselya
    aselya committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    18ce5e0 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Update hasCrossSiteAncestor.md 

    Updates for clarity
    @aselya
    aselya committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    deb0dd7 View commit details
    Browse the repository at this point in the history

  2. Update hasCrossSiteAncestor.md 

    Update formatting of url
    @aselya
    aselya committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    9d579c2 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. Update hasCrossSiteAncestor.md 

    Updates in phrasing and document organization.
    @aselya
    aselya committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    33d24cc View commit details
    Browse the repository at this point in the history

  2. Update hasCrossSiteAncestor.md 

    Additional details
    @aselya
    aselya committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    e991178 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Update hasCrossSiteAncestor.md 

    Additional content and formatting
    @aselya
    aselya committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    5ce6b56 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Update proposals/hasCrossSiteAncestor.md 

    Update pr to incorporate reviewer feedback.

Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    04e4a6e View commit details
    Browse the repository at this point in the history

  2. Update proposals/hasCrossSiteAncestor.md 

    Update to reflect reviewer suggestion.

Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    327ea24 View commit details
    Browse the repository at this point in the history

  3. Update proposals/hasCrossSiteAncestor.md 

    Update to remove reference to Chrome

Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    150ffbf View commit details
    Browse the repository at this point in the history

  4. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    0c88b2f View commit details
    Browse the repository at this point in the history

  5. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    f064146 View commit details
    Browse the repository at this point in the history

  6. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    c341071 View commit details
    Browse the repository at this point in the history

  7. Update hasCrossSiteAncestor.md 

    Add use case
    @aselya
    aselya committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    769663c View commit details
    Browse the repository at this point in the history

  8. Update hasCrossSiteAncestor.md 

    Added background information on x-site ancestor chain bit
    @aselya
    aselya committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    70a3280 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Update hasCrossSiteAncestor.md 

    Update language for cookies.remove()
    @aselya
    aselya committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    ffb23e1 View commit details
    Browse the repository at this point in the history

  2. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
    @aselya @oliverdunk
    aselya and oliverdunk committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    582b880 View commit details
    Browse the repository at this point in the history

  3. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
    @aselya @oliverdunk
    aselya and oliverdunk committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    b209dd4 View commit details
    Browse the repository at this point in the history

  4. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
    @aselya @oliverdunk
    aselya and oliverdunk committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    bce3162 View commit details
    Browse the repository at this point in the history

  5. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
    @aselya @oliverdunk
    aselya and oliverdunk committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    b71a7a7 View commit details
    Browse the repository at this point in the history

  6. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
    @aselya @oliverdunk
    aselya and oliverdunk committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    1bcf678 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
    @aselya @oliverdunk
    aselya and oliverdunk committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    845f868 View commit details
    Browse the repository at this point in the history

  2. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
    @aselya @oliverdunk
    aselya and oliverdunk committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    b2ef5e7 View commit details
    Browse the repository at this point in the history

  3. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
    @aselya @oliverdunk
    aselya and oliverdunk committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    ab5eaaa View commit details
    Browse the repository at this point in the history

  4. Update hasCrossSiteAncestor.md 

    Add new use case and add clarification to table
    @aselya
    aselya committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    cdf260f View commit details
    Browse the repository at this point in the history

  5. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    c522cdc View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Update hasCrossSiteAncestor.md

    @aselya
    aselya committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    85428ac View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Update hasCrossSiteAncestor.md 

    Add language describing logic for determining hasCrossSiteAncestor value when not provided. Update method descriptions to incorporate new language and indicate when errors will be thrown.
    @aselya
    aselya committed May 30, 2024
    Configuration menu
    Copy the full SHA
    86f0e7f View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Update hasCrossSiteAncestor.md 

    Update table
    @aselya
    aselya committed May 31, 2024
    Configuration menu
    Copy the full SHA
    e244fef View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    64a15c5 View commit details
    Browse the repository at this point in the history

  2. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    cd75fce View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Update hasCrossSiteAncestor.md 

    Removing language for ancestor bit definition that is no longer needed.
    @aselya
    aselya committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    5a3d145 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Update hasCrossSiteAncestor.md 

    Update the description of cookies.remove()
    @aselya
    aselya committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    131b666 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Heiko Theißen <heiko.theissen@sap.com>
    @aselya @HeikoTheissen
    aselya and HeikoTheissen committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    a831db7 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Update hasCrossSiteAncestor.md 

    Add language that explicitly allows for get(), getAll() and remove() to have values that would not be valid for set(). To allow for migration of cookies that are no longer valid at runtime.
    @aselya
    aselya committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    44a8e80 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    04a9fee View commit details
    Browse the repository at this point in the history

  2. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    3faee04 View commit details
    Browse the repository at this point in the history

  3. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    a6bf397 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Update hasCrossSiteAncestor.md 

    Add language to privacy to point out the pre-existing risks associated with editing partition keys
    @aselya
    aselya committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    bdf8077 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f83b18f View commit details
    Browse the repository at this point in the history

  2. Update hasCrossSiteAncestor.md

    @aselya
    aselya committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    3a8e2ba View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Update hasCrossSiteAncestor.md 

    Add description for getPartitionKey() api.
    @aselya
    aselya committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    8e05e8d View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Update hasCrossSiteAncestor.md 

    Updating language for getAll() to align it with the other APIs, where a partitionKey with no topLevelSite and a value for hasCrossSiteAncestor returns an error.
    @aselya
    aselya committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0d83efa View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Update hasCrossSiteAncestor.md 

    Update language to specify that `{hasCrossSiteAncestor: false}` and `{hasCrossSiteAncestor:true}` are invalid keys.
    @aselya
    aselya committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    8328697 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Update hasCrossSiteAncestor.md 

    Add table containing valid partitionKeys. Update language in the background section to be more consistent.
    @aselya
    aselya committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9edb236 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Update hasCrossSiteAncestor.md 

    Clarify language surrounding the empty partitionKey
    @aselya
    aselya committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    13ca34f View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: bvandersloot-mozilla <90582190+bvandersloot-mozilla@users.noreply.github.com>
    @aselya @bvandersloot-mozilla
    aselya and bvandersloot-mozilla committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d76d4a1 View commit details
    Browse the repository at this point in the history

  2. Update hasCrossSiteAncestor.md 

    Update language to specify the domain of the cookie's url
    @aselya
    aselya committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    95f4753 View commit details
    Browse the repository at this point in the history

  3. Update hasCrossSiteAncestor.md 

    Return {} to the table of valid partition keys
    @aselya
    aselya committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    0447b92 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    ac34784 View commit details
    Browse the repository at this point in the history

  2. Update hasCrossSiteAncestor.md

    @aselya
    aselya committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    f21810e View commit details
    Browse the repository at this point in the history

  3. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    589dab8 View commit details
    Browse the repository at this point in the history

  4. Update hasCrossSiteAncestor.md 

    Add table describing inputs for getPartitionKey()
    @aselya
    aselya committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    39aefc9 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7d42807 View commit details
    Browse the repository at this point in the history

  2. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    0aed648 View commit details
    Browse the repository at this point in the history

  3. Update proposals/hasCrossSiteAncestor.md 

    Co-authored-by: Rob Wu <rob@robwu.nl>
    @aselya @Rob--W
    aselya and Rob--W committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    cfe1825 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Update hasCrossSiteAncestor.md 

    describe error conditions of new api
    @aselya
    aselya committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    92b747d View commit details
    Browse the repository at this point in the history