Reject create(Uni|Bi)directionalStream() on stream ID exhaustion. #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a little bit confused. I remember last time we discussed this in #469, the conclusion was that we're supposed to block the promise until the next stream is available. Have I missed something? |
|
My understanding from the May 23 meeting notes and #446 (comment) was that we wanted to rethink this:
I believe the thinking was that blocking the promise made it difficult for the application to detect that the MAX_STREAM_LIMIT has been hit, and that waiting wasn't always the right cause of action. Rejecting instead would let the application know what happened so it can decide what to do next. |
|
But how can the app know when the limit has been increased and it is safe to call Create*Stream() again? |
github-actions bot
added a commit
that referenced
this pull request
Sep 26, 2023
SHA: 40e83a0 Reason: push, by jan-ivar Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #446.
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Jul 19, 2023, 7:52 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.